Agentic UI: Strip local domain suffix from publish flow domain suggestion - #4743
Merged
Conversation
bcotrim
changed the title
Collaborator
📊 Performance Test ResultsComparing 123e0a5 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
wojtekn
approved these changes
Sep 3, 2026
wojtekn
left a comment
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the fix.
| if ( domain.endsWith( DEFAULT_CUSTOM_DOMAIN_SUFFIX ) ) { | ||
| return domain.slice( 0, -DEFAULT_CUSTOM_DOMAIN_SUFFIX.length ); | ||
| } | ||
| if ( domain.endsWith( '.local' ) ) { |
Contributor
There was a problem hiding this comment.
It could be constant, too, but it's a minor nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Written with Claude Code (analysis, implementation, tests); reviewed by me.
Proposed Changes
Following "Create a new WordPress site" from the publish/sync flow prefilled the WordPress.com domain search with the site's local domain (e.g.
mysite.wp.local), so the first screen in the handoff showed an "invalid domain" warning instead of suggestions.stripLocalDomainSuffixhelper inpackages/commonnow derives the suggestion: the exact.wp.localsuffix (Studio's default) is stripped entirely; otherwise only a single trailing.locallabel is removed, somysite.com.localsuggestsmysite.com..wp.local).Testing Instructions
<site-name>.wp.local).mysite.localprefillsmysite;mysite.com.localprefillsmysite.com.Pre-merge Checklist